d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When doing ARM stack unwinding as part of stack_save(9), do not search

Browse Source 
loaded modules (pass 0/false for the can_lock arg).  Searching the unwind
info in modules acquires an exclusive sxlock, and the stack(9) functions can
be called in a context where unbounded sleeps are forbidden (such as from
the witness checkorder code).

Just ignoring the existence of modules in stack_save() is not ideal, so I'm
looking for a better solution, but this commit will make it possible to boot
an ARM kernel with WITNESS enabled again, until I get something better.

PR:		242200
This commit is contained in:
Ian Lepore 2019-11-24 21:08:56 +00:00
parent 71b8e362c5
commit b39d851dcb
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=355069
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/arm/arm/stack_machdep.c
View File

@ -40,7 +40,7 @@ stack_capture(struct stack *st, struct unwind_state *state)
{
stack_zero(st);
while (unwind_stack_one(state, 1) == 0) {
while (unwind_stack_one(state, 0) == 0) {
if (stack_put(st, state->registers[PC]) == -1)
break;
}