d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't repeat handshake.

Browse Source 
This little thing can cause a deadlock, because taste mechanism start
to work after creation of ggate provider and I/O requests are sent from
other classes from the g_event thread, so number of pending events isn't 0.
Now ggatec(8) start second handshake and ggated(8) is trying to open
GEOM provider (for example md(4)) and it can't, because it hangs on
g_waitidle() in g_dev_open(). g_waitidle() cannot finish because
there is a pending read on event queue, and this read can't be
finished, because ggated(8) can't open target device.
GEOM Gate will recover from this deadlock, because requests will
timeout, but it of course isn't the best solution and I don't know
better one for now, so we should avoid opening GEOM providers while
there are pending requests in event queue.
This commit is contained in:
Pawel Jakub Dawidek 2004-05-03 18:24:41 +00:00
parent 4d1e1bf3f5
commit b42b646004
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=128882
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sbin/ggate/ggatec/ggatec.c
View File

@ -289,15 +289,15 @@ serve_loop(int sfd)
for (;;) {
int error;
error = serve(sfd);
close(sfd);
if (error != EAGAIN)
g_gate_xlog("%s.", strerror(error));
sfd = handshake();
if (sfd < 0) {
sleep(2);
continue;
}
error = serve(sfd);
close(sfd);
if (error != EAGAIN)
g_gate_xlog("%s.", strerror(error));
}
}