d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tcp: keep SACK scoreboard sorted when doing rescue retransmission

Browse Source 
Reviewed By: tuexen, kbowling, #transport
MFC after: 3 days
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D29825
This commit is contained in:
Richard Scheffenegger 2021-04-18 22:14:14 +02:00
parent 3357e9482f
commit b87cf2bc84
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/netinet/tcp_sack.c
View File

@ -497,7 +497,7 @@ static struct sackhole *
tcp_sackhole_insert(struct tcpcb *tp, tcp_seq start, tcp_seq end,
struct sackhole *after)
{
struct sackhole *hole;
struct sackhole *hole, *tail;
/* Allocate a new SACK hole. */
hole = tcp_sackhole_alloc(tp, start, end);
@ -508,7 +508,15 @@ tcp_sackhole_insert(struct tcpcb *tp, tcp_seq start, tcp_seq end,
if (after != NULL)
TAILQ_INSERT_AFTER(&tp->snd_holes, after, hole, scblink);
else
TAILQ_INSERT_TAIL(&tp->snd_holes, hole, scblink);
/*
* With Rescue Retransmission, new holes may need to
* be inserted just before the tail.
*/
if (((tail = TAILQ_LAST_FAST(&tp->snd_holes, sackhole,
scblink)) != NULL) && SEQ_LEQ(end, tail->start))
TAILQ_INSERT_BEFORE(tail, hole, scblink);
else
TAILQ_INSERT_TAIL(&tp->snd_holes, hole, scblink);
/* Update SACK hint. */
if (tp->sackhint.nexthole == NULL)