If no arguments are passed to a subcommand that requires arguments,

error out before we deref a null pointer in the check for max length.

Thanks to otis in IRC for the bug report.

MFC after:	3 days
This commit is contained in:
Sean Bruno 2015-02-15 23:58:57 +00:00
parent 7034d8df04
commit b8fc9a86a8
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=278827

View File

@ -371,8 +371,10 @@ add_cmd(__unused int argc, char *argv[], ximgact_binmisc_entry_t *xbe)
}
int
name_cmd(__unused int argc, char *argv[], ximgact_binmisc_entry_t *xbe)
name_cmd(int argc, char *argv[], ximgact_binmisc_entry_t *xbe)
{
if (argc == 0)
usage("Required argument missing\n");
if (strlen(argv[0]) > IBE_NAME_MAX)
usage("'%s' string length longer than IBE_NAME_MAX (%d)",
IBE_NAME_MAX);