d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't waste so much space for the latency debugging buffer. Its size

Browse Source 
will now need editing except for spot checks.

Changed this buffer from a circular one to a linear one.  This is more
useful for some cases and the sysctl that prints it doesn't support
circular buffers.

Fixed (output) formatting bugs in this sysctl.  An off by 1 error caused
a garbage byte to be returned after annotation of large deltas, and
a race with the writer sometimes caused premature string termination.
This commit is contained in:
Bruce Evans 2003-11-16 23:05:52 +00:00
parent 10b4620bf0
commit b9c29fa9ae
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=122819
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/dev/sio/sio.c
View File

@ -1730,7 +1730,7 @@ siointr(arg)
#endif /* COM_MULTIPORT */
}
static struct timespec siots[8192];
static struct timespec siots[8];
static int siotso;
static int volatile siotsunit = -1;
@ -1740,17 +1740,17 @@ sysctl_siots(SYSCTL_HANDLER_ARGS)
char buf[128];
long long delta;
size_t len;
int error, i;
int error, i, tso;
for (i = 1; i < siotso; i++) {
for (i = 1, tso = siotso; i < tso; i++) {
delta = (long long)(siots[i].tv_sec - siots[i - 1].tv_sec) *
1000000000 +
(siots[i].tv_nsec - siots[i - 1].tv_nsec);
len = sprintf(buf, "%lld\n", delta);
if (delta >= 110000)
len += sprintf(buf + len - 1, ": *** %ld.%09ld\n",
(long)siots[i].tv_sec, siots[i].tv_nsec);
if (i == siotso - 1)
(long)siots[i].tv_sec, siots[i].tv_nsec) - 1;
if (i == tso - 1)
buf[len - 1] = '\0';
error = SYSCTL_OUT(req, buf, len);
if (error != 0)
@ -1922,11 +1922,9 @@ if (com->iptr - com->ibuf == 8)
} else {
outb(com->data_port, *ioptr++);
++com->bytes_out;
if (com->unit == siotsunit) {
nanouptime(&siots[siotso]);
siotso = (siotso + 1) %
(sizeof siots / sizeof siots[0]);
}
if (com->unit == siotsunit
&& siotso < sizeof siots / sizeof siots[0])
nanouptime(&siots[siotso++]);
}
com->obufq.l_head = ioptr;
if (COM_IIR_TXRDYBUG(com->flags))