d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't allow interfaces to be renamed to the empty string.

Browse Source 
While I'm here, errors aren't bools.

Pointed out by:	hmp
This commit is contained in:
Brooks Davis 2004-03-13 02:35:03 +00:00
parent 196f7f54d2
commit bc1470f1f1
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=126901
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/net/if.c
View File

@ -1348,11 +1348,13 @@ ifhwioctl(u_long cmd, struct ifnet *ifp, caddr_t data, struct thread *td)
case SIOCSIFNAME:
error = suser(td);
if (error)
if (error != 0)
return (error);
error = copyinstr(ifr->ifr_data, new_name, IFNAMSIZ, NULL);
if (error)
if (error != 0)
return (error);
if (new_name[0] == '\0')
return (EINVAL);
if (ifunit(new_name) != NULL)
return (EEXIST);