d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bad timespec_subtract() calculations produce negative tv_nsec on i386

Browse Source 
which cause EINVAL returned from nanosleep() which cause loop in
cron_sleep() and making all cron jobs to start about 30 seconds earlier
(which cause f.e. logfiles rotation by newsyslog delayed by 1 hour).

Use simple and proved calculations from kernel's timespecsub() instead.

MFC after:      3 days
This commit is contained in:
Andrey A. Chernov 2014-01-25 02:16:09 +00:00
parent b3f2918a25
commit bc36ff9bc7
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=261146
1 changed files with 7 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
usr.sbin/cron/cron/cron.c
View File

@ -376,30 +376,17 @@ cron_sync(int secres) {
}
}
static int
static void
timespec_subtract(struct timespec *result, struct timespec *x,
struct timespec *y)
{
time_t nsec;
/* Perform the carry for the later subtraction by updating y. */
if (x->tv_nsec < y->tv_nsec) {
nsec = (y->tv_nsec - x->tv_nsec) / 10000000 + 1;
y->tv_nsec -= 1000000000 * nsec;
y->tv_sec += nsec;
*result = *x;
result->tv_sec -= y->tv_sec;
result->tv_nsec -= y->tv_nsec;
if (result->tv_nsec < 0) {
result->tv_sec--;
result->tv_nsec += 1000000000;
}
if (x->tv_nsec - y->tv_nsec > 1000000000) {
nsec = (x->tv_nsec - y->tv_nsec) / 1000000000;
y->tv_nsec += 1000000000 * nsec;
y->tv_sec -= nsec;
}
/* tv_nsec is certainly positive. */
result->tv_sec = x->tv_sec - y->tv_sec;
result->tv_nsec = x->tv_nsec - y->tv_nsec;
/* Return True if result is negative. */
return (x->tv_sec < y->tv_sec);
}
static void