d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove comparisons which are not necessary.

Browse Source 
Reported by:	Coverity
CID:		1237826, 1237844, 1237847
MFC after:	1 week
This commit is contained in:
Michael Tuexen 2015-01-20 19:08:55 +00:00
parent 20ef3b88cd
commit bcbf8c2105
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=277424
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/netinet/sctp_sysctl.c
View File

@ -569,8 +569,12 @@ sctp_sysctl_handle_udp_tunneling(SYSCTL_HANDLER_ARGS)
error = sysctl_handle_int(oidp, &new, 0, req);
if ((error == 0) &&
(req->newptr != NULL)) {
#if (SCTPCTL_UDP_TUNNELING_PORT_MIN == 0)
if (new > SCTPCTL_UDP_TUNNELING_PORT_MAX) {
#else
if ((new < SCTPCTL_UDP_TUNNELING_PORT_MIN) ||
(new > SCTPCTL_UDP_TUNNELING_PORT_MAX)) {
#endif
error = EINVAL;
} else {
SCTP_INP_INFO_WLOCK();
@ -598,9 +602,14 @@ sctp_sysctl_handle_auth(SYSCTL_HANDLER_ARGS)
error = sysctl_handle_int(oidp, &new, 0, req);
if ((error == 0) &&
(req->newptr != NULL)) {
#if (SCTPCTL_AUTH_ENABLE_MIN == 0)
if ((new > SCTPCTL_AUTH_ENABLE_MAX) ||
((new == 0) && (SCTP_BASE_SYSCTL(sctp_asconf_enable) == 1))) {
#else
if ((new < SCTPCTL_AUTH_ENABLE_MIN) ||
(new > SCTPCTL_AUTH_ENABLE_MAX) ||
((new == 0) && (SCTP_BASE_SYSCTL(sctp_asconf_enable) == 1))) {
#endif
error = EINVAL;
} else {
SCTP_BASE_SYSCTL(sctp_auth_enable) = new;
@ -619,9 +628,14 @@ sctp_sysctl_handle_asconf(SYSCTL_HANDLER_ARGS)
error = sysctl_handle_int(oidp, &new, 0, req);
if ((error == 0) &&
(req->newptr != NULL)) {
#if (SCTPCTL_ASCONF_ENABLE_MIN == 0)
if ((new > SCTPCTL_ASCONF_ENABLE_MAX) ||
((new == 1) && (SCTP_BASE_SYSCTL(sctp_auth_enable) == 0))) {
#else
if ((new < SCTPCTL_ASCONF_ENABLE_MIN) ||
(new > SCTPCTL_ASCONF_ENABLE_MAX) ||
((new == 1) && (SCTP_BASE_SYSCTL(sctp_auth_enable) == 0))) {
#endif
error = EINVAL;
} else {
SCTP_BASE_SYSCTL(sctp_asconf_enable) = new;