d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix style bugs in the last commit.

Browse Source
This commit is contained in:
Brian Feldman 2000-01-21 02:52:54 +00:00
parent 2621949f6f
commit bd9079fa6c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=56359
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/kern/kern_descrip.c
View File

@ -937,16 +937,16 @@ fdfree(p)
}
/*
* For setuid/setgid programs we don't want to people to use that setuidness
* For setugid programs, we don't want to people to use that setugidness
* to generate error messages which write to a file which otherwise would
* otherwise be off limits to the proces.
* otherwise be off-limits to the process.
*
* This is a gross hack to plug the hole. A better solution would involve
* a special vop or other form of generalized access control mechanism. We
* go ahead and just reject all procfs file systems accesses as dangerous.
*
* Since setugidsafety calls this only for fd 0, 1 and 2, this check is
* sufficient. We also don't for setugidness since we know we are.
* sufficient. We also don't for check setugidness since we know we are.
*/
static int
is_unsafe(struct file *fp)
@ -975,15 +975,13 @@ setugidsafety(p)
fpp = fdp->fd_ofiles;
fdfp = fdp->fd_ofileflags;
for (i = 0; i <= fdp->fd_lastfile; i++, fpp++, fdfp++) {
if (i > 2)
break;
for (i = 0; i <= 2 && i <= fdp->fd_lastfile; i++, fpp++, fdfp++) {
if (*fpp != NULL && is_unsafe(*fpp)) {
if (*fdfp & UF_MAPPED)
(void) munmapfd(p, i);
(void) closef(*fpp, p);
if ((*fdfp & UF_MAPPED) != 0)
(void)munmapfd(p, i);
(void)closef(*fpp, p);
*fpp = NULL;
*fdfp = 0;
*fdfp = '\0';
if (i < fdp->fd_freefile)
fdp->fd_freefile = i;
}