d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent possible usage of uninitialized pbase variable by checking

Browse Source 
return value of fdt_get_range
This commit is contained in:
Oleksandr Tymoshenko 2012-12-13 03:35:47 +00:00
parent b388a69a8d
commit be9914fc31
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=244171
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/uart/uart_bus_fdt.c
View File

@ -206,8 +206,10 @@ uart_cpu_getdev(int devtype, struct uart_devinfo *di)
err = fdt_regsize(node, &start, &size);
if (err)
return (ENXIO);
err = fdt_get_range(OF_parent(node), 0, &pbase, &psize);
if (err)
pbase = 0;
fdt_get_range(OF_parent(node), 0, &pbase, &psize);
start += pbase;
return (bus_space_map(di->bas.bst, start, size, 0, &di->bas.bsh));