d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sysctl(3): Implement SYSCTL_FOREACH() to iterate all OIDs in a sysctl list.

Browse Source 
To avoid using the sysctl list macros directly in external kernel modules.

Reviewed by:		asomers, manu and asiciliano
Differential Revision:	https://reviews.freebsd.org/D36748
MFC after:	1 week
Sponsored by:	NVIDIA Networking
This commit is contained in:
Hans Petter Selasky 2022-09-27 15:48:16 +02:00
parent f2963b530e
commit c075ea46bc
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/kern/kern_sysctl.c
View File

@ -136,7 +136,7 @@ sysctl_find_oidname(const char *name, struct sysctl_oid_list *list)
struct sysctl_oid *oidp;
SYSCTL_ASSERT_LOCKED();
RB_FOREACH(oidp, sysctl_oid_list, list) {
SYSCTL_FOREACH(oidp, list) {
if (strcmp(oidp->oid_name, name) == 0) {
return (oidp);
}
@ -1005,7 +1005,7 @@ sysctl_sysctl_debug_dump_node(struct sysctl_oid_list *l, int i)
struct sysctl_oid *oidp;
SYSCTL_ASSERT_LOCKED();
RB_FOREACH(oidp, sysctl_oid_list, l) {
SYSCTL_FOREACH(oidp, l) {
for (k=0; k<i; k++)
printf(" ");
@ -1327,7 +1327,7 @@ name2oid(char *name, int *oid, int *len, struct sysctl_oid **oidpp)
for (*len = 0; *len < CTL_MAXNAME;) {
p = strsep(&name, ".");
RB_FOREACH(oidp, sysctl_oid_list, lsp) {
SYSCTL_FOREACH(oidp, lsp) {
if (strcmp(p, oidp->oid_name) == 0)
break;
}

3
sys/sys/sysctl.h
View File

@ -918,6 +918,9 @@ TAILQ_HEAD(sysctl_ctx_list, sysctl_ctx_entry);
NULL); \
})
#define SYSCTL_FOREACH(oidp, list) \
RB_FOREACH(oidp, sysctl_oid_list, list)
/*
* A macro to generate a read-only sysctl to indicate the presence of optional
* kernel features.