From c083134268b9a0b94801374691e01a5bf5602f4a Mon Sep 17 00:00:00 2001 From: Luigi Rizzo Date: Mon, 12 Apr 2010 08:27:53 +0000 Subject: [PATCH] fix a buffer overflow with large (100k+) number of input lines. MFC after: 3 days --- sbin/ipfw/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/ipfw/main.c b/sbin/ipfw/main.c index cd39cf13bfdf..43693e0e1226 100644 --- a/sbin/ipfw/main.c +++ b/sbin/ipfw/main.c @@ -553,11 +553,11 @@ ipfw_readfile(int ac, char *av[]) } while (fgets(buf, BUFSIZ, f)) { /* read commands */ - char linename[10]; + char linename[20]; char *args[2]; lineno++; - sprintf(linename, "Line %d", lineno); + snprintf(linename, sizeof(linename), "Line %d", lineno); setprogname(linename); /* XXX */ args[0] = progname; args[1] = buf;