d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net80211: Move rate printing in amrr_node_stats() to a separate method

Browse Source 
This makes amrr_node_stats() cleaner and allows the rate printing to be
reusable.

Submitted by:	Neel Chauhan <neel at neelc.org>
Reviewed by:	adrian
Differential Revision:	https://reviews.freebsd.org/D22318
This commit is contained in:
Conrad Meyer 2020-01-17 22:04:11 +00:00
parent ac64d0f1ea
commit c1475a191e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=356852
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
sys/net80211/ieee80211_amrr.c
View File

@ -477,18 +477,12 @@ amrr_sysctlattach(struct ieee80211vap *vap,
}
static void
amrr_node_stats(struct ieee80211_node *ni, struct sbuf *s)
amrr_print_node_rate(struct ieee80211_amrr_node *amn,
struct ieee80211_node *ni, struct sbuf *s)
{
int rate;
struct ieee80211_amrr_node *amn = ni->ni_rctls;
struct ieee80211_rateset *rs;
/* XXX TODO: check locking? */
if (!amn)
return;
/* XXX TODO: this should be a method */
if (amrr_node_is_11n(ni)) {
rs = (struct ieee80211_rateset *) &ni->ni_htrates;
rate = rs->rs_rates[amn->amn_rix] & IEEE80211_RATE_VAL;
@ -498,7 +492,19 @@ amrr_node_stats(struct ieee80211_node *ni, struct sbuf *s)
rate = rs->rs_rates[amn->amn_rix] & IEEE80211_RATE_VAL;
sbuf_printf(s, "rate: %d Mbit\n", rate / 2);
}
}
static void
amrr_node_stats(struct ieee80211_node *ni, struct sbuf *s)
{
struct ieee80211_amrr_node *amn = ni->ni_rctls;
/* XXX TODO: check locking? */
if (!amn)
return;
amrr_print_node_rate(amn, ni, s);
sbuf_printf(s, "ticks: %d\n", amn->amn_ticks);
sbuf_printf(s, "txcnt: %u\n", amn->amn_txcnt);
sbuf_printf(s, "success: %u\n", amn->amn_success);