d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set spl_kmem_cache_reclaim=0 to default

Browse Source 
Reinstate the correct default behavior of returning the number of objects
in the cache for reclaim.  This behavior was disabled in recent releases
to do occasional reports of spinning in shrink_slabs().  Those issues have
been resolved and can no longer can be reproduced.  See commit 376dc35.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: DHE <git@dehacked.net>
Issue #358
Closes #379
This commit is contained in:
Brian Behlendorf 2014-08-07 16:14:41 -07:00
parent 2bf35fb754
commit c1aef26944
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
module/spl/spl-kmem.c
View File

@ -58,12 +58,13 @@ module_param(spl_kmem_cache_expire, uint, 0644);
MODULE_PARM_DESC(spl_kmem_cache_expire, "By age (0x1) or low memory (0x2)"); MODULE_PARM_DESC(spl_kmem_cache_expire, "By age (0x1) or low memory (0x2)");
/* /*
* KMC_RECLAIM_ONCE is set as the default until zfsonlinux/spl#268 is * The default behavior is to report the number of objects remaining in the
* definitively resolved. Depending on the system configuration and * cache. This allows the Linux VM to repeatedly reclaim objects from the
* workload this may increase the likelihood of out of memory events. * cache when memory is low satisfy other memory allocations. Alternately,
* For those cases it is advised that this option be set to zero. * setting this value to KMC_RECLAIM_ONCE limits how aggressively the cache
* is reclaimed. This may increase the likelihood of out of memory events.
*/ */
unsigned int spl_kmem_cache_reclaim = KMC_RECLAIM_ONCE; unsigned int spl_kmem_cache_reclaim = 0;
module_param(spl_kmem_cache_reclaim, uint, 0644); module_param(spl_kmem_cache_reclaim, uint, 0644);
MODULE_PARM_DESC(spl_kmem_cache_reclaim, "Single reclaim pass (0x1)"); MODULE_PARM_DESC(spl_kmem_cache_reclaim, "Single reclaim pass (0x1)");