d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

if_stf: Delete unreachable code

Browse Source 
As the flag M_WAITOK is passed to ip_encap_attach(), then the function
will never return NULL, and the following code within NULL check branch
will be unreachable.

No functional change intended.

Reviewed by:	kp
Fixes:		6d8fdfa9d5 Rework IP encapsulation handling code
MFC after:	1 week
Differential Revision:  https://reviews.freebsd.org/D39746
This commit is contained in:
Zhenlei Huang 2023-04-23 12:47:57 +08:00
parent 04989ef426
commit c373e1d6ad
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/net/if_stf.c
View File

@ -295,12 +295,6 @@ stf_clone_create(struct if_clone *ifc, char *name, size_t len,
ifp->if_dunit = IF_DUNIT_NONE;
sc->encap_cookie = ip_encap_attach(&ipv4_encap_cfg, sc, M_WAITOK);
if (sc->encap_cookie == NULL) {
if_printf(ifp, "attach failed\n");
free(sc, M_STF);
ifc_free_unit(ifc, unit);
return (ENOMEM);
}
ifp->if_mtu = IPV6_MMTU;
ifp->if_ioctl = stf_ioctl;