sfxge: do not use DEBUG_FLAGS to enable extra debug checks
DEBUG_FLAGS are set to DEBUG option value when kernel is built. For example, it is -g in GENERIC config to have debug symbols. Also DEBUG_FLAGS are used to determine if ctfconvert should keep debug symbols. Since we redefined DEBUG_FLAGS, debug symbols were always missing. ctfconvert complains about it during kernel build. It is incorrect to append DEBUG_FLAGS, since if DEBUG has no -g (or similar), we'll have no debug symbols and ctfconvert will complain. If it incorrect to always have -g in our DEBUG_FLAGS, since debug symbols presence should be controllable by kernel config. So, just add disabled by default addition of -DDEBUG=1 to CFLAGS. Reviewed by: imp Sponsored by: Solarflare Communications, Inc. MFC after: 2 days Differential Revision: https://reviews.freebsd.org/D2666
This commit is contained in:
parent
78fd538146
commit
c378187825
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=283679
@ -36,6 +36,6 @@
|
||||
#ifndef _SFXGE_VERSION_H
|
||||
#define _SFXGE_VERSION_H
|
||||
|
||||
#define SFXGE_VERSION_STRING "v4.5.1.1018"
|
||||
#define SFXGE_VERSION_STRING "v4.5.2.1000"
|
||||
|
||||
#endif /* _SFXGE_DRIVER_VERSION_H */
|
||||
|
@ -34,6 +34,7 @@ SRCS+= hunt_nvram.c hunt_rx.c hunt_phy.c hunt_sram.c hunt_tx.c hunt_vpd.c
|
||||
SRCS+= hunt_filter.c
|
||||
SRCS+= hunt_impl.h
|
||||
|
||||
DEBUG_FLAGS= -DDEBUG=1
|
||||
# Extra debug checks
|
||||
#CFLAGS += -DDEBUG=1
|
||||
|
||||
.include <bsd.kmod.mk>
|
||||
|
Loading…
Reference in New Issue
Block a user