d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: Build warnings with different gcc optimization levels in debug mode

Browse Source 
This fix resolves warnings reported during compiling with different gcc
optimization levels in debug mode,

Test tools:
gcc version 4.4.7 20120313 (Red Hat 4.4.7-16) (GCC)
Linux version: 2.6.32-573.18.1.el6.x86_64, Red Hat Enterprise Linux Server release 6.1 (Santiago)

List of warnings:
CFLAGS=-O1 ./configure --enable-debug ;make
../../module/icp/core/kcf_sched.c: In function ‘kcf_aop_done’:
../../module/icp/core/kcf_sched.c:499: error: ‘fg’ may be used uninitialized in this function
../../module/icp/core/kcf_sched.c:499: note: ‘fg’ was declared here

CFLAGS=-Os ./configure --enable-debug ; make
libzfs_dataset.c: In function ‘zfs_prop_set_list’:
libzfs_dataset.c:1575: error: ‘nvl_len’ may be used uninitialized in this function

Signed-off-by: GeLiXin <ge.lixin@zte.com.cn>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #5022
This commit is contained in:
GeLiXin 2016-08-25 16:40:20 +08:00 committed by Brian Behlendorf
parent 67925abb5e
commit c40db193a5
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libzfs/libzfs_dataset.c Normal file → Executable file
View File

@ -1572,7 +1572,7 @@ zfs_prop_set_list(zfs_handle_t *zhp, nvlist_t *props)
char errbuf[1024]; char errbuf[1024];
libzfs_handle_t *hdl = zhp->zfs_hdl; libzfs_handle_t *hdl = zhp->zfs_hdl;
nvlist_t *nvl; nvlist_t *nvl;
int nvl_len; int nvl_len = 0;
int added_resv = 0; int added_resv = 0;
zfs_prop_t prop = 0; zfs_prop_t prop = 0;
nvpair_t *elem; nvpair_t *elem;
@ -1602,7 +1602,6 @@ zfs_prop_set_list(zfs_handle_t *zhp, nvlist_t *props)
* Check how many properties we're setting and allocate an array to * Check how many properties we're setting and allocate an array to
* store changelist pointers for postfix(). * store changelist pointers for postfix().
*/ */
nvl_len = 0;
for (elem = nvlist_next_nvpair(nvl, NULL); for (elem = nvlist_next_nvpair(nvl, NULL);
elem != NULL; elem != NULL;
elem = nvlist_next_nvpair(nvl, elem)) elem = nvlist_next_nvpair(nvl, elem))

2
module/icp/core/kcf_sched.c Normal file → Executable file
View File

@ -496,7 +496,7 @@ kcf_resubmit_request(kcf_areq_node_t *areq)
kcf_provider_desc_t *new_pd; kcf_provider_desc_t *new_pd;
crypto_mechanism_t *mech1 = NULL, *mech2 = NULL; crypto_mechanism_t *mech1 = NULL, *mech2 = NULL;
crypto_mech_type_t prov_mt1, prov_mt2; crypto_mech_type_t prov_mt1, prov_mt2;
crypto_func_group_t fg; crypto_func_group_t fg = 0;
if (!can_resubmit(areq, &mech1, &mech2, &fg)) if (!can_resubmit(areq, &mech1, &mech2, &fg))
return (error); return (error);