Do not leak rv->psind in some specific situations.

Suppose that we have an object with a mapped superpage, and that all
pages in the superpages are held (by some driver).  Additionally,
suppose that the object is terminated, e.g. because the only process
mapping it is exiting.  Then the reservation is broken, but the pages
cannot be freed until later, when they are unheld.  In this situation,
the reservation code cannot clean psind, since no pages are freed, and
the page is freed and then reused with invalid psind.

Clean psind on vm_reserv_break() to avoid the situation.

Reported and tested by:	Slava Shwartsman
Reviewed by:	markj
Sponsored by:	Mellanox Technologies
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D14335
This commit is contained in:
Konstantin Belousov 2018-02-13 15:36:28 +00:00
parent c688c9051b
commit c4be9169c0
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=329215

View File

@ -949,6 +949,7 @@ vm_reserv_break(vm_reserv_t rv, vm_page_t m)
vm_domain_free_assert_locked(VM_DOMAIN(rv->domain));
vm_reserv_remove(rv);
rv->pages->psind = 0;
if (m != NULL) {
/*
* Since the reservation is being broken, there is no harm in