d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix warnings and bump WARNS to 6

Browse Source 
- Garbage collect argc/argv (-Wunused)
- sleep(3) will always return an unsigned int; don't check for return codes <0
  (-Wsign-compare)

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2015-04-11 03:13:09 +00:00
parent 572e1f51aa
commit c7ded8ba9e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=281393
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/regression/sockets/sblock/Makefile
View File

@ -4,6 +4,6 @@
PROG= sblock
MAN=
WARNS?= 2
WARNS?= 6
.include <bsd.prog.mk>

12
tools/regression/sockets/sblock/sblock.c
View File

@ -54,7 +54,7 @@
static int interrupted;
static void
signal_handler(int signum)
signal_handler(int signum __unused)
{
interrupted++;
@ -95,7 +95,7 @@ locking_recver(int fd)
ssize_t len;
char ch;
if (sleep(1) < 0)
if (sleep(1) != 0)
err(-1, "FAIL: locking_recver: sleep");
len = recv(fd, &ch, sizeof(ch), 0);
if (len < 0 && errno != EINTR)
@ -116,7 +116,7 @@ signaller(pid_t locking_recver_pid, int fd)
ssize_t len;
char ch;
if (sleep(2) < 0) {
if (sleep(2) != 0) {
warn("signaller sleep(2)");
return;
}
@ -124,7 +124,7 @@ signaller(pid_t locking_recver_pid, int fd)
warn("signaller kill(%d)", locking_recver_pid);
return;
}
if (sleep(1) < 0) {
if (sleep(1) != 0) {
warn("signaller sleep(1)");
return;
}
@ -141,14 +141,14 @@ signaller(pid_t locking_recver_pid, int fd)
warn("signaller close");
return;
}
if (sleep(1) < 0) {
if (sleep(1) != 0) {
warn("signaller sleep(1)");
return;
}
}
int
main(int argc, char *argv[])
main(void)
{
int error, fds[2], recver_fd, sender_fd;
pid_t blocking_recver_pid;