d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rather than not redirting the bp when we get ENXIO, only redirty it

Browse Source 
when the error is EIO.  This catches a much larger class of errors
that are unlikely to succeed if retried.

Submitted by: bde
This commit is contained in:
Warner Losh 2007-12-30 05:53:45 +00:00
parent 9dd49f960f
commit c94a7cac1f
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=174992
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/kern/vfs_bio.c
View File

@ -1168,19 +1168,13 @@ brelse(struct buf *bp)
return;
}
if (bp->b_iocmd == BIO_WRITE &&
(bp->b_ioflags & BIO_ERROR) &&
bp->b_error != ENXIO &&
!(bp->b_flags & B_INVAL)) {
if (bp->b_iocmd == BIO_WRITE && (bp->b_ioflags & BIO_ERROR) &&
bp->b_error == EIO && !(bp->b_flags & B_INVAL)) {
/*
* Failed write, redirty. Must clear BIO_ERROR to prevent
* pages from being scrapped. If B_INVAL is set then
* this case is not run and the next case is run to
* destroy the buffer. B_INVAL can occur if the buffer
* is outside the range supported by the underlying device.
* If the error is that the device went away (ENXIO), we
* shouldn't redirty the buffer either, but discard the
* data too.
* pages from being scrapped. If the error is anything
* other than an I/O error (EIO), assume that retryingi
* is futile.
*/
bp->b_ioflags &= ~BIO_ERROR;
bdirty(bp);