d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use register_t instead of uintptr_t for register values in backtraces.

Browse Source 
This fixes backtraces from DDB in n32 kernels as uintptr_t is only a
uint32_t.  In particular, the upper 32-bits of each register value were
treated as the register's value breaking both the output of register
values, but also the values of 'ra' and 'sp' required to walk up to the
previous frame.

Sponsored by:	DARPA / AFRL
This commit is contained in:
John Baldwin 2016-12-13 19:36:05 +00:00
parent 6c941e4724
commit ca311cf72b
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=310030
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/mips/mips/db_trace.c
View File

@ -139,8 +139,8 @@ stacktrace_subr(register_t pc, register_t sp, register_t ra,
* of these registers is valid, e.g. obtained from the stack
*/
int valid_args[4];
uintptr_t args[4];
uintptr_t va, subr;
register_t args[4];
register_t va, subr;
unsigned instr, mask;
unsigned int frames = 0;
int more, stksize, j;
@ -379,7 +379,7 @@ stacktrace_subr(register_t pc, register_t sp, register_t ra,
if (j > 0)
(*printfn)(",");
if (valid_args[j])
(*printfn)("%x", args[j]);
(*printfn)("%jx", (uintmax_t)(u_register_t)args[j]);
else
(*printfn)("?");
}