From cb4fbe4ebb44105919bb2804b05057757c9d89f8 Mon Sep 17 00:00:00 2001
From: Kyle Evans <kevans@FreeBSD.org>
Date: Fri, 2 Mar 2018 02:39:41 +0000
Subject: [PATCH] lualoader: Use #str instead of tracking length with 'n'

We really gain almost nothing by tracking length separately, especially when
it's as easy as "#str", so reduce complexity.
---
 stand/lua/password.lua | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/stand/lua/password.lua b/stand/lua/password.lua
index c8352ea519d7..551cfd075024 100644
--- a/stand/lua/password.lua
+++ b/stand/lua/password.lua
@@ -42,7 +42,6 @@ local twiddle_chars = {"/", "-", "\\", "|"}
 -- Module exports
 function password.read(prompt_length)
 	local str = ""
-	local n = 0
 	local twiddle_pos = 1
 
 	local function draw_twiddle()
@@ -60,14 +59,13 @@ function password.read(prompt_length)
 			break
 		end
 		if ch == core.KEY_BACKSPACE or ch == core.KEY_DELETE then
-			if n > 0 then
-				n = n - 1
+			if #str > 0 then
 				if show_password_mask then
 					loader.printc("\008 \008")
 				else
 					draw_twiddle()
 				end
-				str = str:sub(1, n)
+				str = str:sub(1, #str - 1)
 			end
 		else
 			if show_password_mask then
@@ -76,7 +74,6 @@ function password.read(prompt_length)
 				draw_twiddle()
 			end
 			str = str .. string.char(ch)
-			n = n + 1
 		end
 	end
 	return str