d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid underflowing a variable, which would result in taking more

Browse Source 
data from the stream queues then needed.

Thanks to Timo Voelker for finding this bug and providing a fix.

MFC after:		3 days
This commit is contained in:
Michael Tuexen 2020-05-05 19:54:30 +00:00
parent 6a7016194d
commit cb9fb7b2cb
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=360671
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/netinet/sctp_output.c
View File

@ -7763,7 +7763,11 @@ sctp_fill_outqueue(struct sctp_tcb *stcb,
}
strq = stcb->asoc.ss_functions.sctp_ss_select_stream(stcb, net, asoc);
total_moved += moved;
space_left -= moved;
if (space_left >= moved) {
space_left -= moved;
} else {
space_left = 0;
}
if (space_left >= SCTP_DATA_CHUNK_OVERHEAD(stcb)) {
space_left -= SCTP_DATA_CHUNK_OVERHEAD(stcb);
} else {