Fix Coverity issues

- Initialize .sun_len before passing it to strlcpy and bind.
- Close fd on error

MFC after:	3 days
Reported by:	Coverity
CID:		978283, 979581
This commit is contained in:
Enji Cooper 2017-01-04 02:46:36 +00:00
parent 251d8e776e
commit cc34906655
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=311233

View File

@ -243,12 +243,19 @@ sockets_main(int argc, char **argv)
return EXIT_FAILURE;
}
#ifdef __FreeBSD__
addr.sun_len = sizeof(addr.sun_path);
(void)strlcpy(addr.sun_path, argv[1], addr.sun_len);
#else
(void)strlcpy(addr.sun_path, argv[1], sizeof(addr.sun_path));
#endif
addr.sun_family = PF_UNIX;
error = bind(fd, (struct sockaddr *)&addr, sizeof(addr));
if (error == -1) {
warn("connect");
#ifdef __FreeBSD__
(void)close(fd);
#endif
return EXIT_FAILURE;
}