From cc4adc4c4e473d47b687d2ac2757157abd728c81 Mon Sep 17 00:00:00 2001 From: Ed Maste Date: Wed, 29 Mar 2023 21:33:39 -0400 Subject: [PATCH] makefs: remove vestigial '?' cases from top-level getopt(3) loop getopt(3) returns '?' when it encounters a flag not present in the in the optstring or if a flag is missing its option argument. We can handle this case with the "default" failure case with no loss of legibility. Obtained from: OpenBSD makefs.c 1.22 --- usr.sbin/makefs/makefs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/makefs/makefs.c b/usr.sbin/makefs/makefs.c index 2b97c7643e1a..e775b72fd4bb 100644 --- a/usr.sbin/makefs/makefs.c +++ b/usr.sbin/makefs/makefs.c @@ -273,7 +273,6 @@ main(int argc, char *argv[]) fsoptions.sparse = 1; break; - case '?': default: usage(fstype, &fsoptions); /* NOTREACHED */