From cd1e6e70d001bea9e9e0220bdfdbd8b5dd9922de Mon Sep 17 00:00:00 2001
From: Ihor Antonov <ihor@antonovs.family>
Date: Thu, 2 Mar 2023 23:17:02 -0600
Subject: [PATCH] daemon: simplify if/else chain

Reviewed by:	kevans
Pull Request:	https://github.com/freebsd/freebsd-src/pull/672
---
 usr.sbin/daemon/daemon.c | 34 +++++++++++++++++++++-------------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/usr.sbin/daemon/daemon.c b/usr.sbin/daemon/daemon.c
index 5c636bcd0a03..2274a3e253a0 100644
--- a/usr.sbin/daemon/daemon.c
+++ b/usr.sbin/daemon/daemon.c
@@ -452,22 +452,16 @@ main(int argc, char *argv[])
 		 */
 		if (child_gone && child_eof) {
 			break;
-		} else if (terminate) {
+		}
+
+		if (terminate) {
 			goto exit;
-		} else if (!child_eof) {
-			if (sigprocmask(SIG_BLOCK, &mask_read, NULL)) {
-				warn("sigprocmask");
-				goto exit;
-			}
-			child_eof = !listen_child(pfd[0], &logparams);
-			if (sigprocmask(SIG_UNBLOCK, &mask_read, NULL)) {
-				warn("sigprocmask");
-				goto exit;
-			}
-		} else {
+		}
+
+		if (child_eof) {
 			if (sigprocmask(SIG_BLOCK, &mask_susp, NULL)) {
 				warn("sigprocmask");
-	 			goto exit;
+				goto exit;
 			}
 			while (!terminate && !child_gone)
 				sigsuspend(&mask_orig);
@@ -475,7 +469,21 @@ main(int argc, char *argv[])
 				warn("sigprocmask");
 				goto exit;
 			}
+			continue;
 		}
+
+		if (sigprocmask(SIG_BLOCK, &mask_read, NULL)) {
+			warn("sigprocmask");
+			goto exit;
+		}
+
+		child_eof = !listen_child(pfd[0], &logparams);
+
+		if (sigprocmask(SIG_UNBLOCK, &mask_read, NULL)) {
+			warn("sigprocmask");
+			goto exit;
+		}
+
 	}
 	if (restart && !terminate) {
 		daemon_sleep(restart, 0);