d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

proc_init: Fix a few memory leaks of 'phdl'

Browse Source 
In the normal case and correct failure cases, the 'phdl' pointer is passed to
callers to use or clean up as needed.  However, some failure cases returned
early, failing to export the phdl pointer.

This was introduced in the restructuring of r303533.

Reported by:	Coverity
CID:		1361070
Reviewed by:	markj
Sponsored by:	EMC / Isilon Storage Division
This commit is contained in:
Conrad Meyer 2016-08-02 18:13:50 +00:00
parent 0cd7a91aa7
commit ce601a2676
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=303669
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/libproc/proc_create.c
View File

@ -73,9 +73,9 @@ proc_init(pid_t pid, int flags, int status, struct proc_handle **pphdl)
struct proc_handle *phdl;
int error, class, count, fd;
*pphdl = NULL;
error = ENOMEM;
if ((phdl = malloc(sizeof(*phdl))) == NULL)
return (ENOMEM);
goto out;
memset(phdl, 0, sizeof(*phdl));
phdl->pid = pid;
@ -83,17 +83,17 @@ proc_init(pid_t pid, int flags, int status, struct proc_handle **pphdl)
phdl->status = status;
phdl->procstat = procstat_open_sysctl();
if (phdl->procstat == NULL)
return (ENOMEM);
goto out;
/* Obtain a path to the executable. */
if ((kp = procstat_getprocs(phdl->procstat, KERN_PROC_PID, pid,
&count)) == NULL)
return (ENOMEM);
goto out;
error = procstat_getpathname(phdl->procstat, kp, phdl->execpath,
sizeof(phdl->execpath));
procstat_freeprocs(phdl->procstat, kp);
if (error != 0)
return (error);
goto out;
/* Use it to determine the data model for the process. */
if ((fd = open(phdl->execpath, O_RDONLY)) < 0) {