d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a workaround for a bug when setting the Raspberry GIO config and state

Browse Source 
The Raspberry Pi GPIO config and state messages incorrectly return with
the tag length set to 0. We then check this value to have the response
flag set. Work around this by setting the response flag when setting the
GPIO config or state and this value is zero.

Sponsored by:	Innovate UK
This commit is contained in:
Andrew Turner 2020-07-28 11:32:45 +00:00
parent a4dea14159
commit ce69217c7b
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=363647
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/arm/broadcom/bcm2835/bcm2835_mbox.c
View File

@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$");
#include <dev/ofw/ofw_bus.h>
#include <dev/ofw/ofw_bus_subr.h>
#include <arm/broadcom/bcm2835/bcm2835_firmware.h>
#include <arm/broadcom/bcm2835/bcm2835_mbox.h>
#include <arm/broadcom/bcm2835/bcm2835_mbox_prop.h>
#include <arm/broadcom/bcm2835/bcm2835_vcbus.h>
@ -362,6 +363,16 @@ bcm2835_mbox_err(device_t dev, bus_addr_t msg_phys, uint32_t resp_phys,
tag = (struct bcm2835_mbox_tag_hdr *)(msg + 1);
last = (uint8_t *)msg + len;
for (idx = 0; tag->tag != 0; idx++) {
/*
* When setting the GPIO config or state the firmware doesn't
* set tag->val_len correctly.
*/
if ((tag->tag == BCM2835_FIRMWARE_TAG_SET_GPIO_CONFIG ||
tag->tag == BCM2835_FIRMWARE_TAG_SET_GPIO_STATE) &&
tag->val_len == 0) {
tag->val_len = BCM2835_MBOX_TAG_VAL_LEN_RESPONSE |
tag->val_buf_size;
}
if ((tag->val_len & BCM2835_MBOX_TAG_VAL_LEN_RESPONSE) == 0) {
device_printf(dev, "tag %d response error\n", idx);
return (EIO);