d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixup the parameters to audit_submit(3) the order is errno then return

Browse Source 
value.  This bug went un-noticed for so long because EPERM == 1

MFC after:	1 week
Spotted by:	sson, rwatson
This commit is contained in:
Christian S.J. Peron 2009-04-04 20:58:18 +00:00
parent 4ef9925138
commit ce8c6d71f5
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=190700
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
usr.bin/su/su.c
View File

@ -231,7 +231,7 @@ main(int argc, char *argv[])
if (strlen(user) > MAXLOGNAME - 1) { if (strlen(user) > MAXLOGNAME - 1) {
#ifdef USE_BSM_AUDIT #ifdef USE_BSM_AUDIT
if (audit_submit(AUE_su, auid, if (audit_submit(AUE_su, auid,
1, EPERM, "username too long: '%s'", user)) EPERM, 1, "username too long: '%s'", user))
errx(1, "Permission denied"); errx(1, "Permission denied");
#endif #endif
errx(1, "username too long"); errx(1, "username too long");
@ -264,7 +264,7 @@ main(int argc, char *argv[])
pwd = getpwuid(ruid); pwd = getpwuid(ruid);
if (pwd == NULL) { if (pwd == NULL) {
#ifdef USE_BSM_AUDIT #ifdef USE_BSM_AUDIT
if (audit_submit(AUE_su, auid, 1, EPERM, if (audit_submit(AUE_su, auid, EPERM, 1,
"unable to determine invoking subject: '%s'", username)) "unable to determine invoking subject: '%s'", username))
errx(1, "Permission denied"); errx(1, "Permission denied");
#endif #endif
@ -305,7 +305,7 @@ main(int argc, char *argv[])
retcode = pam_authenticate(pamh, 0); retcode = pam_authenticate(pamh, 0);
if (retcode != PAM_SUCCESS) { if (retcode != PAM_SUCCESS) {
#ifdef USE_BSM_AUDIT #ifdef USE_BSM_AUDIT
if (audit_submit(AUE_su, auid, 1, EPERM, "bad su %s to %s on %s", if (audit_submit(AUE_su, auid, EPERM, 1, "bad su %s to %s on %s",
username, user, mytty)) username, user, mytty))
errx(1, "Permission denied"); errx(1, "Permission denied");
#endif #endif
@ -326,7 +326,7 @@ main(int argc, char *argv[])
pwd = getpwnam(user); pwd = getpwnam(user);
if (pwd == NULL) { if (pwd == NULL) {
#ifdef USE_BSM_AUDIT #ifdef USE_BSM_AUDIT
if (audit_submit(AUE_su, auid, 1, EPERM, if (audit_submit(AUE_su, auid, EPERM, 1,
"unknown subject: %s", user)) "unknown subject: %s", user))
errx(1, "Permission denied"); errx(1, "Permission denied");
#endif #endif
@ -342,7 +342,7 @@ main(int argc, char *argv[])
aerr = pam_strerror(pamh, retcode); aerr = pam_strerror(pamh, retcode);
if (aerr == NULL) if (aerr == NULL)
aerr = "Unknown PAM error"; aerr = "Unknown PAM error";
if (audit_submit(AUE_su, auid, 1, EPERM, if (audit_submit(AUE_su, auid, EPERM, 1,
"pam_chauthtok: %s", aerr)) "pam_chauthtok: %s", aerr))
errx(1, "Permission denied"); errx(1, "Permission denied");
#endif #endif
@ -353,7 +353,7 @@ main(int argc, char *argv[])
} }
if (retcode != PAM_SUCCESS) { if (retcode != PAM_SUCCESS) {
#ifdef USE_BSM_AUDIT #ifdef USE_BSM_AUDIT
if (audit_submit(AUE_su, auid, 1, EPERM, "pam_acct_mgmt: %s", if (audit_submit(AUE_su, auid, EPERM, 1, "pam_acct_mgmt: %s",
pam_strerror(pamh, retcode))) pam_strerror(pamh, retcode)))
errx(1, "Permission denied"); errx(1, "Permission denied");
#endif #endif
@ -368,7 +368,7 @@ main(int argc, char *argv[])
else { else {
if (ruid != 0) { if (ruid != 0) {
#ifdef USE_BSM_AUDIT #ifdef USE_BSM_AUDIT
if (audit_submit(AUE_su, auid, 1, EPERM, if (audit_submit(AUE_su, auid, EPERM, 1,
"only root may use -c")) "only root may use -c"))
errx(1, "Permission denied"); errx(1, "Permission denied");
#endif #endif