d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libbe(3): Document the import bug...

Browse Source
This commit is contained in:
Kyle Evans 2018-08-11 04:09:42 +00:00
parent a6061733c6
commit d2a6bc9fa5
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/projects/bectl/; revision=337605
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libbe/be.c
View File

@ -696,7 +696,6 @@ be_import(libbe_handle_t *lbh, const char *bootenv, int fd)
strftime(buf + len, BE_MAXPATHLEN - len,
"@%F-%T", localtime(&rawtime));
/* lzc_receive(SNAPNAME, PROPS, ORIGIN, FORCE, fd)) { */
if ((err = lzc_receive(buf, NULL, NULL, false, fd)) != 0) {
switch (err) {
case EINVAL:
@ -724,7 +723,8 @@ be_import(libbe_handle_t *lbh, const char *bootenv, int fd)
nvlist_free(props);
return (be_destroy(lbh, nbuf, 0));
/* XXX TODO: Figure out how to destroy the ghost... */
return (BE_ERR_SUCCESS);
}
#if SOON

15
lib/libbe/libbe.3
View File

@ -170,11 +170,9 @@ An error may occur if:
.It libzfs fails to initialize,
.It The system has not been properly booted with a ZFS boot
environment,
.It
.Nm
.It Nm
fails to open the zpool the active boot environment resides on, or
.It
.Nm
.It Nm
fails to locate the boot environment that is currently mounted.
.El
.Pp
@ -422,7 +420,6 @@ exactly as specified by
The
.Fn be_prop_list_free
function will free the property list.
.Fp
.Sh DIAGNOSTICS
Upon error, one of the following values will be returned.
.\" TODO: make each entry on its own line.
@ -458,5 +455,9 @@ were written as a 2017 Google Summer of Code project with Allan Jude serving
as a mentor.
Later work was done by
.An Kyle Evans Aq Mt kevans@FreeBSD.org .
.\" TODO: update when implementation complete.
.\" .Sh BUGS
.Sh BUGS
The
.Fn be_import
function does not destroy the temporary boot environment it creates for import,
because the snapshot created to do the import may not be deleted since it is the
origin of the new boot environment.