d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Backswards is as backwards does: If we're MPSAFE, then we don't need

Browse Source 
giant, which implies that we need to take out giant it we're NOT
MPSAFE.

# I can't believe the number of people that looked at this failed to
# detect this.
This commit is contained in:
Warner Losh 2003-10-24 07:20:13 +00:00
parent 3a988c5c87
commit d2bda4e032
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=121460
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/pccbb/pccbb.c
View File

@ -1162,10 +1162,10 @@ cbb_intr(void *arg)
*/
if (sc->flags & CBB_CARD_OK) {
STAILQ_FOREACH(ih, &sc->intr_handlers, entries) {
if ((ih->flags & INTR_MPSAFE) != 0)
if ((ih->flags & INTR_MPSAFE) == 0)
mtx_lock(&Giant);
(*ih->intr)(ih->arg);
if ((ih->flags & INTR_MPSAFE) != 0)
if ((ih->flags & INTR_MPSAFE) == 0)
mtx_unlock(&Giant);
}
}