From d41b2be1595f7fdae3314213dc510066895e2b92 Mon Sep 17 00:00:00 2001 From: Jilles Tjoelker Date: Wed, 16 Dec 2015 20:33:47 +0000 Subject: [PATCH] sh: Fix use-after-free when attempting to modify a read-only variable. Reported by: bapt MFC after: 1 week --- bin/sh/var.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/sh/var.c b/bin/sh/var.c index cfba0ba50206..c124a5d51acf 100644 --- a/bin/sh/var.c +++ b/bin/sh/var.c @@ -330,7 +330,7 @@ setvareq(char *s, int flags) if (vp->flags & VREADONLY) { if ((flags & (VTEXTFIXED|VSTACK)) == 0) ckfree(s); - error("%.*s: is read only", vp->name_len, s); + error("%.*s: is read only", vp->name_len, vp->text); } if (flags & VNOSET) { if ((flags & (VTEXTFIXED|VSTACK)) == 0)