d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ping_test: Fix tests ping_46 and ping6_46

Browse Source 
If no IPv4-host, IPv4-mcast-group or IPv6-host is passed, it will
display the usage.  The tests are passing because they are just checking
that the exit code is 1.

Fix the tests by checking the appropriate output message.

While here, change the description to match the output and add the
missing requirements.

Reviewed by:	markj
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D37250
This commit is contained in:
Jose Luis Duran 2022-11-02 08:43:40 -03:00 committed by Mark Johnston
parent fcae0b54d1
commit d481443acb
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sbin/ping/tests/ping_test.sh
View File

@ -129,20 +129,28 @@ ping6_c1t4_body()
ping_46_head()
{
atf_set "descr" "-4 and -6 may not be used together"
atf_set "descr" "-4 and -6 cannot be used simultaneously"
}
ping_46_body()
{
atf_check -s exit:1 -e ignore ping -4 -6
require_ipv4
require_ipv6
atf_check -s exit:1 \
-e match:"-4 and -6 cannot be used simultaneously" \
ping -4 -6 localhost
}
ping6_46_head()
{
atf_set "descr" "-4 and -6 may not be used together"
atf_set "descr" "-4 and -6 cannot be used simultaneously"
}
ping6_46_body()
{
atf_check -s exit:1 -e ignore ping6 -4 -6
require_ipv4
require_ipv6
atf_check -s exit:1 \
-e match:"-4 and -6 cannot be used simultaneously" \
ping6 -4 -6 localhost
}
atf_init_test_cases()