d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not allow the caller to specify the same path for the special

Browse Source 
device file and the mount point.  This prevents the "unexpected recursive
lock" panic from happening.

This is a temporary fix.  A kernel fix would be much much more ugly than
this, and still wouldn't be the "right" way to fix it.  After some
of Terry's file system rework is installed, it will be possible to
properly fix this problem in a clean manner.  Until then,
this change should prevent use from getting a problem report
on this every month or so (and I just noticed that someone in
one of the freebsd news groups was complaining about this problem, too).
This commit is contained in:
Mike Pritchard 1996-03-10 00:20:28 +00:00
parent 5c2da7893a
commit d48b626da3
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=14445
2 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
sbin/mount/mount.c
View File

@ -262,6 +262,7 @@ mountfs(vfstype, spec, name, flags, options, mntopts)
pid_t pid;
int argc, i, status;
char *optbuf, execname[MAXPATHLEN + 1], mntpath[MAXPATHLEN];
char specpath[MAXPATHLEN];
if (realpath(name, mntpath) != NULL && stat(mntpath, &sb) == 0) {
if (!S_ISDIR(sb.st_mode)) {
@ -273,6 +274,24 @@ mountfs(vfstype, spec, name, flags, options, mntopts)
return (1);
}
/*
* The following check is a kludge to prevent the caller from
* accidently using the file as the special device file and
* the mount point. This will cause a panic due to a recursive
* vnode lock. After some of the planned reworking of the
* file system code is done, the kernel can be fixed properly
* and this stupid check can be removed.
*/
if (realpath(spec, specpath) == NULL) {
warn("%s", specpath);
return (1);
}
if (strcmp(mntpath, specpath) == 0) {
warnx("%s: Special device file and mount point may not be the same",
specpath);
return (1);
}
if (mntopts == NULL)
mntopts = "";

19
sbin/mount_ifs/mount.c
View File

@ -262,6 +262,7 @@ mountfs(vfstype, spec, name, flags, options, mntopts)
pid_t pid;
int argc, i, status;
char *optbuf, execname[MAXPATHLEN + 1], mntpath[MAXPATHLEN];
char specpath[MAXPATHLEN];
if (realpath(name, mntpath) != NULL && stat(mntpath, &sb) == 0) {
if (!S_ISDIR(sb.st_mode)) {
@ -273,6 +274,24 @@ mountfs(vfstype, spec, name, flags, options, mntopts)
return (1);
}
/*
* The following check is a kludge to prevent the caller from
* accidently using the file as the special device file and
* the mount point. This will cause a panic due to a recursive
* vnode lock. After some of the planned reworking of the
* file system code is done, the kernel can be fixed properly
* and this stupid check can be removed.
*/
if (realpath(spec, specpath) == NULL) {
warn("%s", specpath);
return (1);
}
if (strcmp(mntpath, specpath) == 0) {
warnx("%s: Special device file and mount point may not be the same",
specpath);
return (1);
}
if (mntopts == NULL)
mntopts = "";