d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Destroy the mutex in case of error.

Browse Source 
Obtained from:	NetBSD ip_nat.c r1.7
MFC after:	3 days
This commit is contained in:
Cy Schubert 2019-08-28 04:55:03 +00:00
parent 6d7534d8ea
commit d49ffa7664
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=351562
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/contrib/ipfilter/netinet/ip_nat.c
View File

@ -3078,7 +3078,7 @@ ipf_nat_newrdr(fin, nat, ni)
/* creating a new NAT structure for a "RDR" rule (incoming NAT translation) */
/* and (3) building that structure and putting it into the NAT table(s). */
/* */
/* NOTE: natsave should NOT be used top point back to an ipstate_t struct */
/* NOTE: natsave should NOT be used to point back to an ipstate_t struct */
/* as it can result in memory being corrupted. */
/* ------------------------------------------------------------------------ */
nat_t *
@ -3406,6 +3406,7 @@ ipf_nat_insert(softc, softn, nat)
u_int hv0, hv1;
u_int sp, dp;
ipnat_t *in;
int ret;
/*
* Try and return an error as early as possible, so calculate the hash
@ -3488,7 +3489,10 @@ ipf_nat_insert(softc, softn, nat)
nat->nat_mtu[1] = GETIFMTU_4(nat->nat_ifps[1]);
}
return ipf_nat_hashtab_add(softc, softn, nat);
ret = ipf_nat_hashtab_add(softc, softn, nat);
if (ret == -1)
MUTEX_DESTROY(&nat->nat_lock);
return ret;
}