d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vmstat: remove shadow variables

Browse Source 
These appear to simply be the style of arguments are left untouched and
only local variables are modified.  While some may prefer that style
this simply serves to complicate things as they're perfectly writeable.

Reviewed by:	kib
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D36628
This commit is contained in:
Elliott Mitchell 2022-09-20 19:18:23 -07:00 committed by Konstantin Belousov
parent ad8feb1ed9
commit d4d7971849
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
usr.bin/vmstat/vmstat.c
View File

@ -1284,29 +1284,26 @@ static void
print_intrcnts(unsigned long *intrcnts, unsigned long *old_intrcnts,
char *intrnames, unsigned int nintr, size_t istrnamlen, long long period_ms)
{
unsigned long *intrcnt, *old_intrcnt;
char *intrname;
uint64_t inttotal, old_inttotal, total_count, total_rate;
unsigned long count, rate;
unsigned int i;
inttotal = 0;
old_inttotal = 0;
intrname = intrnames;
xo_open_list("interrupt");
for (i = 0, intrcnt=intrcnts, old_intrcnt=old_intrcnts; i < nintr; i++) {
if (intrname[0] != '\0' && (*intrcnt != 0 || aflag)) {
count = *intrcnt - *old_intrcnt;
for (i = 0; i < nintr; i++) {
if (intrnames[0] != '\0' && (*intrcnts != 0 || aflag)) {
count = *intrcnts - *old_intrcnts;
rate = ((uint64_t)count * 1000 + period_ms / 2) / period_ms;
xo_open_instance("interrupt");
xo_emit("{d:name/%-*s}{ket:name/%s} "
"{:total/%20lu} {:rate/%10lu}\n",
(int)istrnamlen, intrname, intrname, count, rate);
(int)istrnamlen, intrnames, intrnames, count, rate);
xo_close_instance("interrupt");
}
intrname += strlen(intrname) + 1;
inttotal += *intrcnt++;
old_inttotal += *old_intrcnt++;
intrnames += strlen(intrnames) + 1;
inttotal += *intrcnts++;
old_inttotal += *old_intrcnts++;
}
total_count = inttotal - old_inttotal;
total_rate = (total_count * 1000 + period_ms / 2) / period_ms;