d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

getvfsbyname: prefer sizeof to strlen even for constants

Browse Source 
Clang is smart enough to evaluate strlen() of a constant at compile-time.
However, that won't work in the future if we compile libc with
-ffreestanding.

Reported by:	kib
Dissenting:	ngie, cem
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Alan Somers 2019-05-21 15:59:17 +00:00
parent d311d6c467
commit d5fce87d7c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/projects/fuse2/; revision=348054
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/libc/gen/getvfsbyname.c
View File

@ -49,10 +49,11 @@ __FBSDID("$FreeBSD$");
static bool
are_fusefs(const char *fsname, const char *vfc_name)
{
const char fusefs[] = "fusefs";
const char fusefs_dot[] = "fusefs.";
const static char fusefs[] = "fusefs";
const static char fusefs_dot[] = "fusefs.";
return (strncmp(fsname, fusefs_dot, strlen(fusefs_dot)) == 0 &&
return (strncmp(fsname, fusefs_dot, sizeof(fusefs_dot) - 1) == 0 &&
strcmp(fusefs, vfc_name) == 0);
}