From d64c0992e41c86542a0e46be8371fbd2beb1936a Mon Sep 17 00:00:00 2001 From: Pawel Jakub Dawidek Date: Fri, 28 Jan 2011 21:51:40 +0000 Subject: [PATCH] Add comments to places where we treat errors as ciritical, but it is possible to handle them more gracefully. MFC after: 1 week --- sbin/hastd/primary.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sbin/hastd/primary.c b/sbin/hastd/primary.c index a4cd1725537c..7929c1fc06f3 100644 --- a/sbin/hastd/primary.c +++ b/sbin/hastd/primary.c @@ -796,6 +796,7 @@ hastd_primary(struct hast_resource *res) * Create communication channel between parent and child. */ if (proto_client("socketpair://", &res->hr_ctrl) < 0) { + /* TODO: There's no need for this to be fatal error. */ KEEP_ERRNO((void)pidfile_remove(pfh)); pjdlog_exit(EX_OSERR, "Unable to create control sockets between parent and child"); @@ -804,6 +805,7 @@ hastd_primary(struct hast_resource *res) * Create communication channel between child and parent. */ if (proto_client("socketpair://", &res->hr_event) < 0) { + /* TODO: There's no need for this to be fatal error. */ KEEP_ERRNO((void)pidfile_remove(pfh)); pjdlog_exit(EX_OSERR, "Unable to create event sockets between child and parent"); @@ -811,6 +813,7 @@ hastd_primary(struct hast_resource *res) pid = fork(); if (pid < 0) { + /* TODO: There's no need for this to be fatal error. */ KEEP_ERRNO((void)pidfile_remove(pfh)); pjdlog_exit(EX_TEMPFAIL, "Unable to fork"); }