d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fsirand(8): Just use arc4random(3)

Browse Source 
Remove single use of dubious srandomdev(3) + random(3) and replace with
arc4random(3), as is used already in this program.

Follow-up question: Do we really need this program anymore?  In base?
This commit is contained in:
Conrad Meyer 2019-12-13 04:12:13 +00:00
parent 6425a52feb
commit d82e4d759d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=355692
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sbin/fsirand/fsirand.c
View File

@ -83,8 +83,6 @@ main(int argc, char *argv[])
if (argc - optind < 1)
usage();
srandomdev();
/* Increase our data size to the max */
if (getrlimit(RLIMIT_DATA, &rl) == 0) {
rl.rlim_cur = rl.rlim_max;
@ -167,7 +165,7 @@ fsirand(char *device)
if (!printonly) {
/* Randomize fs_id and write out new sblock and backups */
sblock->fs_id[0] = (u_int32_t)time(NULL);
sblock->fs_id[1] = random();
sblock->fs_id[1] = arc4random();
if (sbput(devfd, sblock, sblock->fs_ncg) != 0) {
warn("could not write updated superblock");
return (1);