d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ip_output: always increase "cantfrag" stat if ip_fragment() fails

Browse Source 
While here, join two unlikely cases into one if clause.

Submitted by:		Ivan Rozhuk <rozhuk.im gmail.com>
PR:			265718
Reviewed by:		mjg, melifaro
Differential revision:	https://reviews.freebsd.org/D36584
This commit is contained in:
Gleb Smirnoff 2022-09-14 19:22:40 -07:00
parent 145a50dcda
commit da6715bbb1
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/netinet/ip_output.c
View File

@ -868,16 +868,14 @@ ip_fragment(struct ip *ip, struct mbuf **m_frag, int mtu,
ip_len = ntohs(ip->ip_len);
ip_off = ntohs(ip->ip_off);
if (ip_off & IP_DF) { /* Fragmentation not allowed */
IPSTAT_INC(ips_cantfrag);
return EMSGSIZE;
}
/*
* Must be able to put at least 8 bytes per fragment.
* Packet shall not have "Don't Fragment" flag and have at least 8
* bytes of payload.
*/
if (len < 8)
return EMSGSIZE;
if (__predict_false((ip_off & IP_DF) || len < 8)) {
IPSTAT_INC(ips_cantfrag);
return (EMSGSIZE);
}
/*
* If the interface will not calculate checksums on