d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

posix4_mib: Don't overrun facility_initialized array

Browse Source 
The facility_initialized and facility arrays are the same size and were
intended to be indexed the same.  I believe this mismatch was just a
typo/braino in r208731.

Reported by:	Coverity
CID:		1017430
Sponsored by:	EMC / Isilon Storage Division
This commit is contained in:
Conrad Meyer 2016-04-27 00:10:32 +00:00
parent a286650b08
commit da95a2ae56
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=298678
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/kern/posix4_mib.c
View File

@ -113,9 +113,9 @@ p31b_sysctl_proc(SYSCTL_HANDLER_ARGS)
num = arg2;
if (!P31B_VALID(num))
return (EINVAL);
val = facility_initialized[num] ? facility[num - 1] : 0;
val = facility_initialized[num - 1] ? facility[num - 1] : 0;
error = sysctl_handle_int(oidp, &val, 0, req);
if (error == 0 && req->newptr != NULL && facility_initialized[num])
if (error == 0 && req->newptr != NULL && facility_initialized[num - 1])
facility[num - 1] = val;
return (error);
}
@ -137,7 +137,7 @@ p31b_unsetcfg(int num)
{
facility[num - 1] = 0;
facility_initialized[num -1] = 0;
facility_initialized[num - 1] = 0;
}
int