d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Mfp: r296309

Browse Source 
While there is no dependency interaction, stopping the timer before
freeing the rest of the resources seems more natural and avoids it
being scheduled an extra time when it is no longer needed.

Reviewed by:	gnn, emaste
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D5733
This commit is contained in:
Bjoern A. Zeeb 2016-04-09 10:51:07 +00:00
parent e18b26d377
commit dc95d65555
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=297736
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/netinet/tcp_syncache.c
View File

@ -281,6 +281,12 @@ syncache_destroy(void)
struct syncache *sc, *nsc;
int i;
/*
* Stop the re-seed timer before freeing resources. No need to
* possibly schedule it another time.
*/
callout_drain(&V_tcp_syncache.secret.reseed);
/* Cleanup hash buckets: stop timers, free entries, destroy locks. */
for (i = 0; i < V_tcp_syncache.hashsize; i++) {
@ -304,8 +310,6 @@ syncache_destroy(void)
/* Free the allocated global resources. */
uma_zdestroy(V_tcp_syncache.zone);
free(V_tcp_syncache.hashbase, M_SYNCACHE);
callout_drain(&V_tcp_syncache.secret.reseed);
}
#endif