d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a witness sleep warning to canon_path(), which invokes vput() and hence

Browse Source 
may perform an unbounded sleep.  Remove an XXX comment suggesting that one
be added.

Obtained from:	TrustedBSD Project
This commit is contained in:
Robert Watson 2006-12-29 10:37:32 +00:00
parent d2ad694caa
commit dc97e8c70a
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=165621
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/security/audit/audit_arg.c
View File

@ -669,9 +669,6 @@ audit_arg_upath(struct thread *td, char *upath, u_int64_t flag)
if (ar == NULL)
return;
/*
* XXXAUDIT: Witness warning for possible sleep here?
*/
KASSERT((flag == ARG_UPATH1) || (flag == ARG_UPATH2),
("audit_arg_upath: flag %llu", (unsigned long long)flag));
KASSERT((flag != ARG_UPATH1) || (flag != ARG_UPATH2),

3
sys/security/audit/audit_bsm_klib.c
View File

@ -488,6 +488,9 @@ canon_path(struct thread *td, char *path, char *cpath)
struct filedesc *fdp;
int cisr, error, vfslocked;
WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL,
"canon_path() at %s:%d", __FILE__, __LINE__);
fdp = td->td_proc->p_fd;
bufp = path;
cisr = 0;