d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fuser: fix loop over kinfo_proc array

Browse Source 
The previous code would skip as many entries at the end of the
array as there were zombies in the list.  While here fix type
of cnt.

Submitted by:	Ali Abdallah <ali.abdallah suse.com>
PR:		232702
MFC After:	2 weeks
This commit is contained in:
Gleb Smirnoff 2023-01-09 08:40:20 -08:00
parent 0eccd618a3
commit dd2b23006c
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
usr.bin/fstat/fuser.c
View File

@ -163,12 +163,12 @@ int
do_fuser(int argc, char *argv[])
{
struct consumer *consumer;
struct kinfo_proc *p, *procs;
struct kinfo_proc *procs;
struct procstat *procstat;
struct reqfile *reqfiles;
char *ep, *nlistf, *memf;
int ch, cnt, sig;
unsigned int i, nfiles;
int ch, sig;
unsigned int i, cnt, nfiles;
sig = SIGKILL; /* Default to kill. */
nlistf = NULL;
@ -253,10 +253,9 @@ do_fuser(int argc, char *argv[])
/*
* Walk through process table and look for matching files.
*/
p = procs;
while(cnt--)
if (p->ki_stat != SZOMB)
dofiles(procstat, p++, reqfiles, nfiles);
for (i = 0; i < cnt; i++)
if (procs[i].ki_stat != SZOMB)
dofiles(procstat, &procs[i], reqfiles, nfiles);
for (i = 0; i < nfiles; i++) {
fprintf(stderr, "%s:", reqfiles[i].name);