d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vfs: fix a panic when truncating comming from copy_file_range

Browse Source 
Truncating requires an exclusive lock, but it was not taken if the
filesystem indicates support for shared writes. This only concerns
ZFS.

In particular fixes cp of files which have trailing holes.

Reported by:	bdrewery
This commit is contained in:
Mateusz Guzik 2020-10-09 20:31:42 +00:00
parent 7e8bd70cff
commit deb1339f3f
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=366587
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/kern/vfs_vnops.c
View File

@ -2975,18 +2975,22 @@ vn_write_outvp(struct vnode *outvp, char *dat, off_t outoff, off_t xfer,
bwillwrite();
mp = NULL;
error = vn_start_write(outvp, &mp, V_WAIT);
if (error == 0) {
if (error != 0)
break;
if (growfile) {
error = vn_lock(outvp, LK_EXCLUSIVE);
if (error == 0) {
error = vn_truncate_locked(outvp, outoff + xfer,
false, cred);
VOP_UNLOCK(outvp);
}
} else {
if (MNT_SHARED_WRITES(mp))
lckf = LK_SHARED;
else
lckf = LK_EXCLUSIVE;
error = vn_lock(outvp, lckf);
}
if (error == 0) {
if (growfile)
error = vn_truncate_locked(outvp, outoff + xfer,
false, cred);
else {
if (error == 0) {
error = vn_rdwr(UIO_WRITE, outvp, dat, xfer2,
outoff, UIO_SYSSPACE, IO_NODELOCKED,
curthread->td_ucred, cred, NULL, curthread);