Reduce the scope of the vnode lock such that it does not cover
the various copyouts associated with initializing the process's argv/env data in userspace. It is possible that these copyout operations can fault under memory pressure, possibly resulting in dead locks. This is believed to be safe since none of the copyout_strings() operations need to interact with the vnode here. Submitted by: Zhouyi Zhou PR: kern/111260 Discussed with: kib MFC after: 3 weeks
This commit is contained in:
parent
ed6c3e478f
commit
ded7d39cb9
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=181647
@ -513,6 +513,11 @@ do_execve(td, args, mac_p)
|
||||
goto interpret;
|
||||
}
|
||||
|
||||
/*
|
||||
* NB: We unlock the vnode here because it is believed that none
|
||||
* of the sv_copyout_strings/sv_fixup operations require the vnode.
|
||||
*/
|
||||
VOP_UNLOCK(imgp->vp, 0);
|
||||
/*
|
||||
* Copy out strings (args and env) and initialize stack base
|
||||
*/
|
||||
@ -550,7 +555,6 @@ do_execve(td, args, mac_p)
|
||||
}
|
||||
|
||||
/* close files on exec */
|
||||
VOP_UNLOCK(imgp->vp, 0);
|
||||
fdcloseexec(td);
|
||||
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user