d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor code cleanup in arc_summary.py

Browse Source 
Simplify and inline single-use function div1(); inline twice-used
function div2(); add function comment to zfs_header(); replace
variable "unused" in get_Kstat() with "_" following convention.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
Closes #6802
This commit is contained in:
Scot W. Stevenson 2017-11-03 23:43:53 +01:00 committed by Brian Behlendorf
parent 34c2b3680b
commit df1f129bc4
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
cmd/arc_summary/arc_summary.py
View File

@ -63,7 +63,7 @@ def load_proc_kstats(fn, namespace):
del kstats[0:2]
for kstat in kstats:
kstat = kstat.strip()
name, unused, value = kstat.split()
name, _, value = kstat.split()
Kstat[namespace + name] = D(value)
Kstat = {}
@ -77,17 +77,6 @@ def load_proc_kstats(fn, namespace):
return Kstat
def div1():
sys.stdout.write("\n")
for i in range(18):
sys.stdout.write("%s" % "----")
sys.stdout.write("\n")
def div2():
sys.stdout.write("\n")
def fBytes(b=0):
"""Return human-readable representation of a byte value in
powers of 2 (eg "KiB" for "kibibytes", etc) to two decimal
@ -908,11 +897,13 @@ def _tunable_summary(Kstat):
def zfs_header():
daydate = time.strftime("%a %b %d %H:%M:%S %Y")
"""Print title string with date
"""
daydate = time.strftime('%a %b %d %H:%M:%S %Y')
div1()
sys.stdout.write("ZFS Subsystem Report\t\t\t\t%s" % daydate)
div2()
sys.stdout.write('\n'+'-'*72+'\n')
sys.stdout.write('ZFS Subsystem Report\t\t\t\t%s' % daydate)
sys.stdout.write('\n')
def usage():
@ -975,7 +966,7 @@ def main():
zfs_header()
for page in pages:
page(Kstat)
div2()
sys.stdout.write("\n")
if __name__ == '__main__':