d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Wait for thread count to reach zero in destroy_devl() even when no purge

Browse Source 
method is defined, to avoid memory being modified after free.

Temporarily increase refcount in destroy_devl() to avoid a double free
if dev_rel() is called while waiting for thread count to reach zero.
This commit is contained in:
Tor Egge 2006-10-13 20:49:24 +00:00
parent 675e8ac08c
commit e0c33ad529
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=163328
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/kern/kern_conf.c
View File

@ -658,6 +658,7 @@ destroy_devl(struct cdev *dev)
dev->si_flags &= ~SI_CLONELIST;
}
dev->si_refcount++; /* Avoid race with dev_rel() */
csw = dev->si_devsw;
dev->si_devsw = NULL; /* already NULL for SI_ALIAS */
while (csw != NULL && csw->d_purge != NULL && dev->si_threadcount) {
@ -667,6 +668,10 @@ destroy_devl(struct cdev *dev)
printf("Still %lu threads in %s\n",
dev->si_threadcount, devtoname(dev));
}
while (dev->si_threadcount != 0) {
/* Use unique dummy wait ident */
msleep(&csw, &devmtx, PRIBIO, "devdrn", hz / 10);
}
dev->si_drv1 = 0;
dev->si_drv2 = 0;
@ -681,6 +686,7 @@ destroy_devl(struct cdev *dev)
fini_cdevsw(csw);
}
dev->si_flags &= ~SI_ALIAS;
dev->si_refcount--; /* Avoid race with dev_rel() */
if (dev->si_refcount > 0) {
LIST_INSERT_HEAD(&dead_cdevsw.d_devs, dev, si_list);