d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle device_get_children() errors in more correct way.

Browse Source 
We shouldn't detach until all children are surely destroyed.

Found with:     Coverity Prevent(tm)
CID:            2137
This commit is contained in:
Alexander Motin 2008-11-22 15:35:21 +00:00
parent d7b96565f5
commit e3ae9f65c2
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=185177
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sys/dev/sound/pci/hda/hdac.c
View File

@ -7571,17 +7571,20 @@ static int
hdac_detach(device_t dev)
{
struct hdac_softc *sc;
device_t *devlist = NULL;
int i, devcount;
device_t *devlist;
int i, devcount, error;
if ((error = device_get_children(dev, &devlist, &devcount)) != 0)
return (error);
for (i = 0; i < devcount; i++) {
if ((error = device_delete_child(dev, devlist[i])) != 0) {
free(devlist, M_TEMP);
return (error);
}
}
free(devlist, M_TEMP);
sc = device_get_softc(dev);
device_get_children(dev, &devlist, &devcount);
for (i = 0; devlist != NULL && i < devcount; i++)
device_delete_child(dev, devlist[i]);
if (devlist != NULL)
free(devlist, M_TEMP);
hdac_release_resources(sc);
return (0);