d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't cast inode number or file size down to long or unsigned.

Browse Source 
Since ino_t size is about to change to 64-bits, casts to long would
truncate 64-bit numbers on 32-bit archs.

Sponsored by:	Google Summer of Code 2011
This commit is contained in:
Gleb Kurtsou 2012-05-18 10:15:46 +00:00
parent 788cefe2cb
commit e458cb776e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=235602
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libprocstat/cd9660.c
View File

@ -84,7 +84,7 @@ isofs_filestat(kvm_t *kd, struct vnode *vp, struct vnstat *vn)
}
vn->vn_fsid = dev2udev(kd, mnt.im_dev);
vn->vn_mode = (mode_t)isonode.inode.iso_mode;
vn->vn_fileid = (long)isonode.i_number;
vn->vn_size = (u_long)isonode.i_size;
vn->vn_fileid = isonode.i_number;
vn->vn_size = isonode.i_size;
return (0);
}

4
lib/libprocstat/common_kvm.c
View File

@ -99,9 +99,9 @@ ufs_filestat(kvm_t *kd, struct vnode *vp, struct vnstat *vn)
* comparisons
*/
vn->vn_fsid = dev2udev(kd, inode.i_dev);
vn->vn_fileid = (long)inode.i_number;
vn->vn_fileid = inode.i_number;
vn->vn_mode = (mode_t)inode.i_mode;
vn->vn_size = (u_long)inode.i_size;
vn->vn_size = inode.i_size;
return (0);
}

2
usr.bin/fstat/fstat.c
View File

@ -244,7 +244,7 @@ print_file_info(struct procstat *procstat, struct filestat *fst,
for (d = devs; d != NULL; d = d->next)
if (d->fsid == vn.vn_fsid) {
fsmatch = 1;
if ((unsigned)d->ino == vn.vn_fileid) {
if (d->ino == vn.vn_fileid) {
filename = d->name;
break;
}